Enable SVG-related CSS properties for Servo#383
Draft
mu-mostafa98 wants to merge 2 commits into
Draft
Conversation
mu-mostafa98
force-pushed
the
enable-svg-styling-for-servo
branch
from
f225deb to
8fb5e33
Compare
- Remove engine = gecko gating and servo_pref gating from SVG properties and shorthands. - Update size_of_test. Signed-off-by: Mohamed Mostafa mu-mostafa98@gmail.com
mu-mostafa98
force-pushed
the
enable-svg-styling-for-servo
branch
from
8fb5e33 to
0145c94
Compare
xiaochengh
reviewed
Jun 8, 2026
Contributor
xiaochengh
left a comment
xiaochengh
left a comment
There was a problem hiding this comment.
Thanks for working on this!
We discussed offline and found this all-in-one PR hard to review. We will change the plan:
- First, enable only a small set of properties for basic shapes in Stylo
- And then, implement the basic shapes and these properties in Servo
- Iterate the above process, and progressively enable more properties in Stylo and implement them in Servo
This way we can make sure that we don't introduce any unintended changes.
…and keep SVG only Signed-off-by: Mohamed Mostafa mu-mostafa98@gmail.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable SVG CSS properties needed for Servo system.
from properties that should now be available in Servo builds
this directive so Servo knows to repaint when they change