Remove SwapChains::destroy_all#346
Merged
Merged
Conversation
Taym95
approved these changes
Nov 12, 2025
mrobinson
force-pushed
the
remove-destroy-all
branch
from
November 12, 2025 23:01
8fc0a87 to
a178eea
Compare
mrobinson
enabled auto-merge
November 12, 2025 23:01
This API is a bit dangerous because it assumes that every `SwapChain` in the collection has the same device. I think it would be better to remove it entire to avoid misuse. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
mrobinson
force-pushed
the
remove-destroy-all
branch
from
November 13, 2025 08:18
a178eea to
2c7a3bb
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Nov 13, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Nov 13, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Nov 13, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Nov 13, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This API is a bit dangerous because it assumes that every
SwapChaininthe collection has the same device. I think it would be better to remove
it entirely to avoid misuse.
Signed-off-by: Martin Robinson mrobinson@igalia.com