-
Notifications
You must be signed in to change notification settings - Fork 310
Prepare WebRender for crates.io release #4878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
| version.workspace = true | ||
| authors = ["Glenn Watson <[email protected]>"] | ||
| license = "MPL-2.0" | ||
| repository = "https://github.com/servo/webrender" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we perhaps update the description to mention this is servos fork of webrender? And perhaps remove authors, since it's not a required field (anymore) and not quite accurate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we probably don't need to mention that we're technically a fork. Even though Firefox/Gecko is upstream these days, they don't publish WebRender to crates.io, and if WebRender is like Stylo then their version can't easily be built outside of their tree (it depends on other C++ code in Gecko). So as far as crates.io consumers are concerned, Servo's version is the canonical version.
|
And last comment, perhaps update the upstream URL in the readme to point to the new upstream at https://github.com/mozilla-firefox/firefox/ |
Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
I've done this. Although note that this PR is against the We should probably make the |
|
I've amended this to not upgrade the versions of |
|
I have released WebRender 0.68 now, though I had to make some changes. I've merged them into this commit in the branch. |
|
@mrobinson Thanks! Could we set the |
|
The issue is that because we are constantly resyncing with upstream, the main branch will have its history rewritten. Perhaps it is better to simply update the README in the main branch. In addition, I think we should look into merging our changes upstream and archiving this repository entirely. |
|
Updating the README (and perhaps deleting the code entirely) in the But this is effectively exactly the same issue as we have with Stylo, right? (except we sync less often and the diff is smaller). So I figured it could make sense to use the same solution here as we use there. Getting rid of the repo entirely could make sense, except we probably don't want to have to coordinate with upstream to make releases? And it might be good to have a record of the code that was released? (I also think we're also going to continue to need at least some Cargo.toml patches on top of upstream so as to strip out the Gecko-specific code (e.g. firefox-on-glean)) |
Changes made:
webrenderand in-repo crates that are dependencies ofwebrenderto version 0.68I have not bothered updating the versions of the other in-repo crates that are not dependencies of
webrender(e.g.wrenchand crates that are used bywrenchlikeswgl) as we don't need to publish those and thus their version numbers don't matter, and I figured it would keep the diff a little smaller. But it would be easy to update those too if we wanted to.