Retain 'bad' genes if desired#24
Merged
Merged
Conversation
Modify the convert_gene() function to append a column to the output dataframe that contains all the bad genes for each row from the input dataframe separated by a ','. This adds a new parameter 'bad_genes_col' (bool).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a parameter (
bad_genes_col) to theconvert_gene()function that allows a user to retain unconvertable gene names in an extra column (bad_genes) that gets appended to the output data frame.I added a test for this and documented within the docstring and FAQ page.