perf: don't check for peer certificate chain APIs on CPython/PyPy #171
Conversation
create_default_context() is quite slow on Linux as OpenSSL 3.x verify location loading is painfully slow. I've observed ~15 ms per call. On CPython and PyPy, we can skip this check since we already know the required APIs exist.
|
While I'm here, is SSLContext safe to reuse across requests sessions? Each SSLContext takes ~15 ms to create as we need to load the certifi bundle (invoking the same slow OpenSSL APIs). If we can reuse the same context across sessions, that'd be great! |
|
Not sure why the test suite is failing. It fails locally on main as well. |
I think it's safe to reuse but I am not certain about thread safety ? |
|
pip isn't multi-threaded yet ;) *actually we use Rich which AFAIU does use a separate rendering thread but I can't imagine it'd be performing network requests. |
|
Failing test appears to be a change in Cloudflare DNS |
create_default_context() is quite slow on Linux as OpenSSL 3.x verify location loading is painfully slow. I've observed ~15 ms per call.
On CPython and PyPy, we can skip this check since we already know the required APIs exist.
This is part of my goal of reducing pip's startup time.