Skip to content

Only include envvar key on error to avoid leaking information #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sethvargo merged 1 commit into from
Apr 9, 2025
Merged

Only include envvar key on error to avoid leaking information #127

sethvargo merged 1 commit into from
Apr 9, 2025

Conversation

@sethvargo
Copy link
Owner

@sethvargo sethvargo commented Apr 9, 2025

Closes #125

@sethvargo sethvargo requested a review from Copilot April 9, 2025 13:57
Copilot AI reviewed Apr 9, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@sethvargo sethvargo merged commit 562e9b1 into main Apr 9, 2025
1 check passed
@sethvargo sethvargo deleted the sethvargo/leak branch April 9, 2025 13:59
@sethvargo sethvargo mentioned this pull request Apr 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Do not disclose secret content when failing to validate envs

2 participants

@sethvargo