Add configurable edge scoring for region graph merging#11
Open
donglaiw wants to merge 2 commits intoseung-lab:mainfrom
Open
Add configurable edge scoring for region graph merging#11donglaiw wants to merge 2 commits intoseung-lab:mainfrom
donglaiw wants to merge 2 commits intoseung-lab:mainfrom
Conversation
Allows passing multiple merge thresholds from the CLI so the watershed and region graph are computed once and the merge step is repeated for each threshold, writing indexed output files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Instead of always using max affinity for edge scores, collect all per-edge affinities and compute a configurable score (max, mean, or percentile). This enables experimenting with different merge functions across multiple merge thresholds in a single run. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
edge_score.hpp: DefinesEdgeScoreConfigwith three modes —max(default, backward-compatible),mean, andpNNpercentile (e.g.p75,p90).region_graph.hpp: Collects all per-edge affinities into a vector instead of keeping only the max, then callscompute_edge_score()to reduce to a single score.atomic_chunk.cpp: Accepts an optional merge function argument (max,mean,pNN) before the merge thresholds on the CLI. Watershed + region graph are still computed once; the merge step is repeated per threshold.CLI:
ws param aff high low size dust tag [merge_func] [thresholds...]🤖 Generated with Claude Code