Update rust reference info about closures #1

roxelo · 2021-07-05T20:27:57Z

cc @arora-aman

roxelo

@arora-aman I think there are a few things we want to change. Mainly wording

src/types/closure.md

roxelo · 2021-07-05T22:19:27Z

src/types/closure.md

+
+Regardless of if the data will be read by the closure, i.e. in case of wild card patterns, if a variable defined outside the closure is mentioned within the closure the variable will be captured in its entirety.
+
+## Other traits difference


I think we can actually delete this section. This is because the modified rules stated "the captured values" and we already clarified in the earlier Edition2018 subsection that the values captured are variables that are captured in its entirety

I'm fine removing it

src/types/closure.md

arora-aman · 2021-07-05T20:50:19Z

src/types/closure.md

-}
+### Capturing references in move contexts
+
+Rust doesn't allow moving fields out references as a result in the case of move closures, when the closure takes ownership of a path, it will only take ownership of a prefix of path that runs up until the first dereference (this may be the entire path if there are no dereferences in the path).


moving fields out of

Instead of truncate ... we reborrow the data being accessed throw the reference

src/types/closure.md

arora-aman · 2021-07-06T14:47:22Z

src/types/closure.md

+
+Regardless of if the data will be read by the closure, i.e. in case of wild card patterns, if a variable defined outside the closure is mentioned within the closure the variable will be captured in its entirety.
+
+## Other traits difference


I'm fine removing it

This should be the other form of its.

Remove incorrect apostrophe

Expand on Unicode identifiers.

The phrase 'may not' could mean 'might not' or 'is not allowed to'.

The original sentence could mean that "its destructor is run" and "it is dropped" are two separate possibilities, rather than two names for the same action.

It is not clear if the original intended to mean these as two separate concepts, or synonyms for the same thing.

Fix typos + grammar

array-expr.md: fix typo; 'polish' sentence

example for bindings after at

…rcion Mention "function item type to `fn pointer`" coercion

Co-authored-by: Eric Huss <[email protected]>

Allow users to change status labels

expressions.md: Attempt fixing broken grammar in Mutability paragraph

Document RangeFrom patterns

Fixed link typo in Generics.md

There are definitions of subtrait and supertrait, so use the official terminology.

…rtrait-subtrait Use subtrait/supertrait, not sub-trait, super-trait.

…FC2229

Co-authored-by: Josh Triplett <[email protected]>

workingjubilee and others added 7 commits November 8, 2020 17:52

Add RangeFrom patterns

d845bc3

More formal writing and links

abcacb2

Offer example

51fab18

Expand on Unicode identifiers.

91c95a1

added an example for binding after @

6556204

removed repeated word

0ca365f

added a comma

702bad4

roxelo commented Jul 5, 2021

View reviewed changes

arora-aman reviewed Jul 6, 2021

View reviewed changes

roxelo force-pushed the closure-doc branch 5 times, most recently from 37ce76c to bc0e50c Compare July 9, 2021 00:16

arora-aman force-pushed the closure-doc branch 4 times, most recently from 880405c to 0a9323a Compare July 20, 2021 09:06

carols10cents and others added 12 commits July 20, 2021 20:45

Remove incorrect apostrophe

80f4867

This should be the other form of its.

Merge pull request rust-lang#1076 from carols10cents/patch-1

5b46b59

Remove incorrect apostrophe

Merge pull request rust-lang#1022 from ehuss/ident-unicode

0fe357f

Expand on Unicode identifiers.

minor grammar and typo fixes

83f725f

improve for loop description (copied from 'while let' equivalent)

91b36e4

clean up grammar in 'slice types'

5ae4a38

disambiguate sentence

e4833e4

The phrase 'may not' could mean 'might not' or 'is not allowed to'.

disambiguate sentence

44bac0e

The original sentence could mean that "its destructor is run" and "it is dropped" are two separate possibilities, rather than two names for the same action.

Revert phrase change for destructors.

314567f

It is not clear if the original intended to mean these as two separate concepts, or synonyms for the same thing.

Merge pull request rust-lang#1037 from kklibo/fix_typos

3b7be07

Fix typos + grammar

Mention "function item type to fn pointer" coercion

ae773c1

array-expr.md: Fix typo;'polished' sentence

9dd6a1f

ehuss added 3 commits July 28, 2021 13:45

Merge pull request rust-lang#1080 from daerich/array-typo

4ac12f6

array-expr.md: fix typo; 'polish' sentence

Merge pull request rust-lang#1027 from MarcusDunn/master

5b96df0

example for bindings after at

Merge pull request rust-lang#1079 from JohnTitor/mention-one-more-coe…

4884fe4

…rcion Mention "function item type to `fn pointer`" coercion

arora-aman force-pushed the closure-doc branch 2 times, most recently from 92336ed to 6b88e48 Compare August 2, 2021 09:14

workingjubilee and others added 21 commits August 3, 2021 00:29

add spacing in src/patterns.md

da75d92

Co-authored-by: Eric Huss <[email protected]>

Allow users to change status labels

7d5f0cd

Merge pull request rust-lang#1083 from fee1-dead/master

da6ea9b

Allow users to change status labels

expressions.md: Attempt fixing broken grammar in Mutability paragraph

daa0b48

Merge pull request rust-lang#1084 from daerich/mutctx_typo

0e5ed7a

expressions.md: Attempt fixing broken grammar in Mutability paragraph

Fix recursion_limit example.

064e68d

Update with slice pattern restrictions

76ed5db

Merge pull request rust-lang#900 from workingjubilee/rangefrom-pat

df5799c

Document RangeFrom patterns

Merge pull request rust-lang#1087 from ehuss/fix-recursion_limit-example

1374727

fixed link typo

9797077

Merge pull request rust-lang#1094 from LazaroHurtado/master

e2404ef

Fixed link typo in Generics.md

Use subtrait/supertrait, not sub-trait, super-trait.

8aa82fc

There are definitions of subtrait and supertrait, so use the official terminology.

Merge pull request rust-lang#1095 from waywardmonkeys/consistent-supe…

b5c68b0

…rtrait-subtrait Use subtrait/supertrait, not sub-trait, super-trait.

Update closure types documentation so it includes information about R…

7c776c8

…FC2229

Address comments

124ece6

Copy capture analyis alogrithm from hackmd

fa56c01

Update copy type, optimization, make algorithm (place, mode)

52a9af9

fix stray merge conflict

7944512

Minor edits from Feedback

55c0829

Add details on truncation and ref-uniq

fe03349

Update closure algorithm per #88467 #88477

702a71f

arora-aman force-pushed the closure-doc branch from 6b88e48 to 702a71f Compare October 5, 2021 07:56

Update src/types/closure.md

44f6e1e

Co-authored-by: Josh Triplett <[email protected]>


		Regardless of if the data will be read by the closure, i.e. in case of wild card patterns, if a variable defined outside the closure is mentioned within the closure the variable will be captured in its entirety.

		## Other traits difference

Update rust reference info about closures #1

Are you sure you want to change the base?

Update rust reference info about closures #1

Uh oh!

Conversation

roxelo commented Jul 5, 2021

Uh oh!

roxelo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

roxelo Jul 5, 2021

Choose a reason for hiding this comment

Uh oh!

arora-aman Jul 6, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arora-aman Jul 5, 2021

Choose a reason for hiding this comment

Uh oh!

arora-aman Jul 5, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arora-aman Jul 6, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants