Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a convenient macro for #996
Name matches how other tools call it, like https://docs.qmk.fm/mod_tap
This differs from the second example of Nested tap in https://github.com/qmk/qmk_firmware/blob/78a0adfbb4d2c4e12f93f2a62ded0020d406243e/docs/tap_hold.md#nested-tap-abba-nested-tap. There, it would write
abinstead ofB. Because I don't think there is any easy way to suppress an event that is not used as an input for something in input-remapper (b in this case). When it is seen by the mod_tap macro, the mod_tap macro has to decide what to do, right now, and it will have to inject its default key.A
modeparameter could be introduced later, which could accept something like"QMK_DEFAULT"or"PERMISSIVE_HOLD"and stuff.Or, we could already maybe make
eventcarry aevent.dont_forwardflag, that prevents it from being forwarded. In that case, the mod_tap macro has to inject all the events that arrived while the modifier was held down when it is released.TODO: