-
Notifications
You must be signed in to change notification settings - Fork 202
Better macro architecture #1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
mypy
[mypy] reported by reviewdog 🐶
error: Argument 3 to "Task" has incompatible type "Context | None"; expected "Context" [arg-type]
| context, |
3a3d95a to
e251fcd
Compare
e251fcd to
cedf74c
Compare
d5b73e1 to
cabbb5f
Compare
294aada to
d50a9e9
Compare
e75d6d1 to
b689880
Compare
a41923e to
d699ccf
Compare
42be820 to
3bf45be
Compare
|
@jonasBoss no hard feelings if you are busy with other stuff. Maybe I could just merge this and the other PRs (#1004 and #1007) slowly one by one, and maybe in the future, if you feel like it, make a review and I'll fix any comments in a new PR. |
$foo), instead of wrapping the latter, while leaving the first one raw.The new architecture is certainly bulkier than the old one with all the new classes, but I think it's worth it. New classes are:
Task,Argument,ArgumentConfig,RawValue.Variablehas been extended.Renamed
MacroParsingErrortoMacroErrorbecause this stuff is also flying around during runtime.