chore(ci): harden GitHub Actions workflow security#195
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens GitHub Actions workflow security across the CI and release pipelines by reducing default token permissions, preventing credential persistence during checkout, and mitigating supply-chain risks in release jobs.
Changes:
- Scoped
GITHUB_TOKENpermissions more tightly (workflow-levelcontents: readfor CI/Nix; job-level write permissions only where required in Release Please). - Added
persist-credentials: falseto checkout steps to avoid leaving credentials in the workspace. - Disabled
actions/setup-gocaching in release workflows and moved tag interpolation into an env var to reduce injection/cache-poisoning risk.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/ci.yml | Adds workflow contents: read and disables persisted checkout credentials across CI jobs. |
| .github/workflows/nix.yml | Adds workflow contents: read and disables persisted checkout credentials for the Nix build workflow. |
| .github/workflows/release-please.yml | Moves write permissions to the release-please job, disables persisted checkout credentials, disables Go cache in release job, and hardens tag substitution. |
| .github/workflows/release.yml | Disables persisted checkout credentials and disables Go module cache for the manual re-release workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zizmor audit fixes (v1.26.1): 32 → 13 findings (0 high, 1 medium).
permissions: contents: readto ci.yml and nix.ymlcontents: write+pull-requests: writeto per-job scope in release-please.ymlpersist-credentials: falseto all checkout steps (except nix-vendor-hash.yml which needs credentials for create-pull-request)