⭐ Refactor classes ✏️Write teacher class and modules #23
Conversation
| "High five!" | ||
| end | ||
|
|
||
| end |
There was a problem hiding this comment.
Usually for modules that are going to be included in classes, we use "-able" names, so here it'd be HighFiveable. Module names should be related to the methods that are defined in it.
|
|
||
| def set_performance_rating(rating) | ||
| response = "" | ||
| if rating > 90 |
There was a problem hiding this comment.
set_performance_rating is still common between the ApprenticeTeacher and SeniorTeacher classes. How will you extract it ?
| "Cool, I've always wanted to teach phase #{num}!" | ||
| end | ||
|
|
||
| end |
There was a problem hiding this comment.
There are still some common methods between the Student and Teacher classes.
For eg: name, age, phase methods exist in both the classes.
How will you refactor this?
| response = "Listen, class, this is how everything works. *drops crazy knowledge bomb* ... You're welcome." | ||
| response | ||
| end | ||
|
|
There was a problem hiding this comment.
teach_stuff method is common in both the Teacher and ApprenticeTeacher classes except for a few words. Can you think of a way to extract it into the Parent class?
2 participants
No description provided.