Skip to content

Snehabn #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Snehabn #3

wants to merge 2 commits into from

Conversation

@snehabn
Copy link

@snehabn snehabn commented May 12, 2016

No description provided.

Sneha Narasimhan added 2 commits May 12, 2016 10:29
Creates two modules, learnable and training. Creates two superclasses…
d8974a2 
… school_people and staff. Refactors remaining files. Tests are passing.
Minor formatting change in staff.rb
5f11b69
@snehabn
Copy link
Author

snehabn commented May 12, 2016 •
edited
Loading

@sebabelmar, Hi Seba, please let me know if I can improve on this. Thank you.
p.s. I realize modules might not be necessary here, but I just wanted practice including them into classes.

@sebabelmar
Copy link

sebabelmar commented May 16, 2016

@snehabn great job.
I think modularizing some behavior to practice and inheriting from one common class was a really good approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@snehabn @sebabelmar