Checkpoint 3 #9
Open
Checkpoint 3 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 12, 2016 10:05
…ete salary_setter and add to knowledge giver class
| @@ -0,0 +1,19 @@ | |||
| module PhaseSettable | |||
There was a problem hiding this comment.
If you include this module in both the teacher classes and student, then that is a problem. A student should not have access to the set_phase_teacher method.
How could this be refactored? Have you looked into how to use certain methods from a module and not all methods? Or, what is a different design approach to solve this problem?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jkarnowski