Excited to share this app! - #13
Open
mcvalera wants to merge 22 commits into
Open
Conversation
…figure out session stuff, fix navbars so that only relevant ones appear. next step is login stuff.
Login logout
add edit account stuff
…tainer. nothing broken so far, i think. SO HAPPYYYYY
now able to edit account. built up div for profile info and album contai...
…AAAAAHHHH. also added helpers for users albums and users photos, added album and photo count to profile, and added delete confirmation page. wuhooooo
deleting users as well as all their albums and photos now works. HURRAAA...
…ged in, removed unnecessary bcrypt stuff from User model, add font for title, add album photo count and link to edit and delete account, revise albums migration and change description to text data type, add styling to css
add bcrypt to gemfile and environment, add feed to home page when logged...
…st for email and password. works for first and i think last name
add comments re account edit option not working for username. must test ...
…istration. some bug with passwords..bcrypt issue? displays errors now on the form when registration or login goes awry. revised font for title and color scheme. loooks pretty so yay
everything working except for weird error where can't login after regist...
… now login after registration yay, formatting for tags in index. next need to implement adding a photo and tags to a photo
replace albums with tags in migration, model and everywhere else, can no...
…add multiple tags to a single photo, add default photo to new users, standardize formatting for all forms
implement feature to add photo, add img url for users profile photo, add...
cleaning up code, and adding instructions to readme
There was a problem hiding this comment.
You should move this password check into a method on the user model. user.authenticate(password) is the convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think I got all the necessary stuff as well as some extra things that I was excited to try and learn from. I am looking forward to feedback! I learned so much and had a blast making this project! There are some notes that I put in on the ReadMe doc if you encounter any issues with running this.
I also apologize for all the previous pull requests! I wasn't aware that I was doing a pull request on the main repo as opposed to my own repo. I closed those now.