MVP O P - #24
Open
Ridou wants to merge 78 commits into
Open
Conversation
…nd set the app in spec_helper
In `sinatra_skeleton` we use naive Rack to launch the web server. Students might forget or be mistaken in thinking that **this** starter pack should be launched in the same way. Ensure that we document the assumption that they use Thin to run the server.
There were some deails about the helpers definitions that could trip beginners up e.g: 1. Helpers are only read once 1. They require server restart to be seen 1. Changes are not dynamically re-incorporated 1. etc. Document these expectations *and also* actually use a helper `em()` so that students can understand how they connect to templates.
Get students used to seeing the most popular richer-text syntax.
…ke-task Drop rspec Rake tasks
We were still using `should` which is deprecated.
Update specs to use expect syntax
This test was broken by means of having a redirect respond to POST to `/bands`.
* Make RSpec output read more cleanly * Relocate variable definition
…on-testing-to-challenge-repo Add integration testing to challenge repo
Require version ~>4.1 for ActiveRecord and ActiveSupport
Remove band/demo example code
Update gems via bundle update
…-readme Update README to match intention of master branch
…n-mvc-challenge into add-rollback
Add rollback task to Rakefile
|
WHOA! This pull request looks VERY different. How did you get all these commits from Jessy Farmer and Jeffrey Wescott? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@amgando
Hi Sherif, this is an educational platform and I am starting the 4 feature classroom with a notebook. On this barebones MVP I put the routes for a user to CRUD his own notes. In future releases I will include AJAX to the notebooks to be able to edit on the fly without having to refresh the page. I want to also scroll through last page and next page using drag and drop javascript function. I will be using a youtube API and also read into adding a sinatra chat for social interaction.
Thank you for making these passion projects because I am really motivated to work on this every day, so I will update you progressively.
I wanted to know if by using Javascript with Ajax if it is possible to drag and drop images into a note, and present it.