add sf vm ssh#107
Merged
Merged
Conversation
Changed Files
|
Contributor
There was a problem hiding this comment.
PR Summary
The PR integrates SSH support into the VM commands by registering a new ssh subcommand and updating associated API endpoints and dependencies.
- In src/lib/vm.ts, the SSH command is registered alongside other VM subcommands.
- src/lib/ssh.ts introduces SSH connection logic with manual escaping and a prefixed
ssh://destination which might impact compatibility. - src/helpers/urls.ts now defines the
vms_ssh_getendpoint. - package.json includes new dependencies (
@alphahydrae/exec,shescape) to support SSH functionality.
4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
7871f11 to
57d3a4b
Compare
Contributor
Author
|
I thought about feature flagging this, but the whole VM set up is already feature flagged so this seems fine imo. |
57d3a4b to
0aea323
Compare
0aea323 to
495f94e
Compare
coffinsfcompute
added a commit
that referenced
this pull request
Apr 11, 2025
coffinsfcompute
added a commit
that referenced
this pull request
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.