add cluster option to buy#109
Merged
Merged
Conversation
Changed Files
|
Contributor
There was a problem hiding this comment.
PR Summary
This PR adds a new --cluster option to the sf buy command, allowing users to specify a target cluster for their GPU purchase orders.
- Added
-c, --cluster <cluster>option to the buy command registration insrc/lib/buy/index.tsx - Updated the
getQuotefunction to accept and pass the cluster parameter to the API - Modified the
placeBuyOrderfunction to include the cluster parameter in the request body - There's a bug where the cluster option is not properly passed from
QuoteAndBuycomponent to theBuyOrdercomponent props - The cluster parameter is correctly included in the API request body but missing from the
orderPropsobject that's passed to theBuyOrdercomponent
Greptile AI: The PR adds a new --cluster option to the sf buy command, allowing users to target specific clusters for their GPU purchase orders.
- Added
-c, --cluster <cluster>option in the command registration with proper documentation - Updated
getQuotefunction to accept and forward the cluster parameter to the API - Modified
placeBuyOrderfunction to include cluster in the request body - Bug: The cluster option is extracted in
QuoteAndBuycomponent but not passed to theBuyOrdercomponent props - The cluster parameter needs to be added to the
orderPropsobject in theQuoteAndBuycomponent'suseEffecthook
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add ability to buy on a specific cluster