fix(cluster): output of cluster ls now shows the correct contract id#121
Merged
Conversation
|
Review changes with |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Modified the contract ID display in cluster listing to preserve case sensitivity by replacing the Badge component with Text, ensuring base62 encoded IDs are shown correctly.
- Removed
@inkjs/uiBadge component import and usage insrc/lib/clusters/clusters.tsx - Added custom Text component styling with background color to maintain visual consistency
- Fixed potential data corruption issue where uppercase contract IDs could cause mismatches
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Contributor
Author
|
I thought adding the space via empty space was a hack, but turns out that's exactly how Bade is implemented. |
joshi4
force-pushed
the
sj/fix-contracts-display
branch
from
9f8bd5f to
93776e8
Compare
Contributor
Author
before
after
|
sigmachirality
approved these changes
Apr 16, 2025
We were using a Badge to show the contract id. Badges turns their text to upper case. This is a problem as our contract ids are base62 encoded - where the distinction between lower case and upper case matters.
joshi4
force-pushed
the
sj/fix-contracts-display
branch
from
93776e8 to
ec8fb1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using Bade to show the contract id.
However, badge turns everything to upper case.
This is a problem as our contract ids are base62 encoded - where the
distinction between lower case and upper case matters.