Skip to content

refactor(vm): remove feature flag check for VMs#122

Merged
JohnPhamous merged 1 commit into
mainfrom
johnphamous/product-278-update-cli
Apr 16, 2025
Merged

refactor(vm): remove feature flag check for VMs#122
JohnPhamous merged 1 commit into
mainfrom
johnphamous/product-278-update-cli

Conversation

@JohnPhamous
Copy link
Copy Markdown
Contributor

No description provided.

@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented Apr 16, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  src/lib/vm.ts  25% smaller
  src/index.ts  17% smaller
  src/lib/posthog.ts  0% smaller

@JohnPhamous JohnPhamous merged commit e1c4969 into main Apr 16, 2025
1 check passed
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR removes feature flag controls for VM functionality in the CLI, making VM commands universally available.

  • Removed isFeatureEnabled check in src/lib/vm.ts, converting registerVM to synchronous function
  • Changed FeatureFlags type in src/lib/posthog.ts from 'vms' to empty string, effectively disabling feature flag system
  • Removed await from registerVM(program) call in src/index.ts, making VM commands immediately available
  • Consider potential impact on system resources with unrestricted VM access
  • Recommend adding monitoring/rate limiting if not already in place to handle increased VM command usage

3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Comment thread src/lib/posthog.ts
};

type FeatureFlags = "vms";
type FeatureFlags = "";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Empty string type makes isFeatureEnabled() unusable. Either remove the function entirely or keep the type system for future feature flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant