refactor(vm): remove feature flag check for VMs#122
Merged
Conversation
Changed Files
|
Contributor
There was a problem hiding this comment.
PR Summary
This PR removes feature flag controls for VM functionality in the CLI, making VM commands universally available.
- Removed
isFeatureEnabledcheck insrc/lib/vm.ts, convertingregisterVMto synchronous function - Changed
FeatureFlagstype insrc/lib/posthog.tsfrom 'vms' to empty string, effectively disabling feature flag system - Removed
awaitfromregisterVM(program)call insrc/index.ts, making VM commands immediately available - Consider potential impact on system resources with unrestricted VM access
- Recommend adding monitoring/rate limiting if not already in place to handle increased VM command usage
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| }; | ||
|
|
||
| type FeatureFlags = "vms"; | ||
| type FeatureFlags = ""; |
Contributor
There was a problem hiding this comment.
logic: Empty string type makes isFeatureEnabled() unusable. Either remove the function entirely or keep the type system for future feature flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.