Fix json mode#124
Merged
joshi4 merged 2 commits intoApr 17, 2025
Merged
Conversation
Contributor
joshi4
commented
Apr 17, 2025
- fix(contracts): output well formed json from --json flag
- feat(cli): if json flag is specified do not display app banner or nudge users to upgrade
Contributor
There was a problem hiding this comment.
PR Summary
This PR improves JSON output handling in the CLI by ensuring clean, well-formed JSON for the contracts list --json command and suppressing non-JSON output when using the --json flag.
- Modified
src/lib/contracts/index.tsxto properly format JSON output usingJSON.stringifywith formatting parameters - Added conditional check in
src/index.tsto skip app banner and version check when --json flag is present - Optimized
listContractsfunction call to avoid duplicate execution - Ensures machine-readable output suitable for programmatic consumption
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
sigmachirality
approved these changes
Apr 17, 2025
Member
sigmachirality
left a comment
There was a problem hiding this comment.
can you run deno fmt rq? other lgtm
we may want to spend some time thinking about how to handle more cases of printing to output that we don't want to print in --json mode in a nice way in the future (like, a logger class/closure/object?)
…ge users to upgrade
a73945a to
5baa77b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.