remove instance_group_id#133
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Summary
This PR removes the instance_group_id field from the VMInstance type in the CLI, indicating a change in VM management structure.
- Inconsistency in
src/lib/vm.ts: Table header still includes "Instance group ID" column but corresponding data is not pushed to table rows - Potential table misalignment issue since header has more columns than data rows
- Documentation in README.md should be updated to reflect removal of instance group concept
- Consider adding migration notes if this is a breaking change for existing CLI users
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't work as intended as is going to refactored.