build: fix deno lock file#217
Merged
Merged
Conversation
Contributor
Author
|
@sigmachirality this has reduced the version numbers. can you make sure it's fine? |
Contributor
There was a problem hiding this comment.
Greptile Overview
Summary
This PR corrects the Deno lock file by reverting dependency versions that were incorrectly upgraded in commit ce03b6f. The lock file now properly respects the version constraints defined in deno.json.
Key changes:
- Reverted
@std/assertfrom 1.0.15 to 1.0.11 to match the^1.0.11constraint in deno.json:6 - Downgraded
@types/nodefrom 22.18.12 to 22.18.10 - Downgraded
emoji-regexfrom 10.6.0 to 10.5.0
The previous commit incorrectly resolved @std/assert@^1.0.11 to version 1.0.15, when Deno's lock file should use the minimum satisfying version (1.0.11) for caret ranges. This fix ensures dependency resolution consistency across environments.
Confidence Score: 5/5
- This PR is safe to merge with no risk
- The changes are mechanical lock file corrections that fix an inconsistency introduced in a previous commit. The reverted versions properly align with the version constraints in deno.json, ensuring deterministic dependency resolution across all environments
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| deno.lock | 5/5 | Correctly reverts dependency versions to match constraints in deno.json, fixing lock file inconsistency from previous commit ce03b6f |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant Lock as deno.lock
participant Config as deno.json
participant Deno as Deno Runtime
Note over Dev,Deno: Previous commit ce03b6f introduced inconsistency
Dev->>Deno: deno cache/install
Deno->>Config: Read dependency constraints
Note over Config: @std/assert@^1.0.11 (allows >=1.0.11 <2.0.0)
Deno->>Lock: Update lock file
Lock-->>Lock: Incorrectly resolved to 1.0.15
Note over Lock: Also upgraded @types/node, emoji-regex
Note over Dev,Deno: This PR fixes the inconsistency
Dev->>Lock: Regenerate lock file
Lock->>Config: Check constraints
Config-->>Lock: @std/assert must be ^1.0.11
Lock-->>Lock: Revert to 1.0.11 (minimum valid version)
Lock-->>Lock: Downgrade @types/node: 22.18.12 → 22.18.10
Lock-->>Lock: Downgrade emoji-regex: 10.6.0 → 10.5.0
Note over Lock: Lock file now consistent with deno.json
No files reviewed, no comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

regen lock file