fix: resolve clippy warnings - use derive macros and strip_prefix

Author: kennethdsheridan

src/adapters/secondary/system/linux.rs

@@ -213,8 +213,8 @@ impl LinuxSystemInfoProvider {
         existing_firmware: Option<String>,
     ) -> (Option<String>, Option<String>) {
         // Extract controller name: "nvme0n1" -> "nvme0"
-        let controller = if device_name.starts_with("nvme") {
-            if let Some(pos) = device_name[4..].find('n') {
+        let controller = if let Some(stripped) = device_name.strip_prefix("nvme") {
+            if let Some(pos) = stripped.find('n') {
                 &device_name[..4 + pos]
             } else {
                 device_name

src/domain/entities.rs

@@ -160,7 +160,7 @@ pub struct HardwareInfo {
 }
 
 /// CPU information
-#[derive(Debug, Serialize, Deserialize, Clone)]
+#[derive(Debug, Serialize, Deserialize, Clone, Default)]
 pub struct CpuInfo {
     /// CPU model name
     pub model: String,
@@ -213,31 +213,6 @@ pub struct CpuInfo {
     pub detection_methods: Vec<String>,
 }
 
-impl Default for CpuInfo {
-    fn default() -> Self {
-        Self {
-            model: String::new(),
-            cores: 0,
-            threads: 0,
-            sockets: 0,
-            speed: String::new(),
-            vendor: String::new(),
-            architecture: String::new(),
-            frequency_mhz: 0,
-            frequency_min_mhz: None,
-            frequency_max_mhz: None,
-            cache_l1d_kb: None,
-            cache_l1i_kb: None,
-            cache_l2_kb: None,
-            cache_l3_kb: None,
-            flags: Vec::new(),
-            microarchitecture: None,
-            caches: Vec::new(),
-            detection_methods: Vec::new(),
-        }
-    }
-}
-
 impl CpuInfo {
     /// Set speed string from frequency_mhz
     pub fn set_speed_string(&mut self) {
@@ -313,7 +288,7 @@ pub struct StorageInfo {
 }
 
 /// Storage type classification
-#[derive(Debug, Serialize, Deserialize, Clone, PartialEq, Eq)]
+#[derive(Debug, Serialize, Deserialize, Clone, PartialEq, Eq, Default)]
 pub enum StorageType {
     /// NVMe SSD
     Nvme,
@@ -326,6 +301,7 @@ pub enum StorageType {
     /// Virtual device (should be filtered)
     Virtual,
     /// Unknown type
+    #[default]
     Unknown,
 }
 
@@ -358,12 +334,6 @@ impl StorageType {
     }
 }
 
-impl Default for StorageType {
-    fn default() -> Self {
-        StorageType::Unknown
-    }
-}
-
 /// Storage device information
 #[derive(Debug, Serialize, Deserialize, Clone)]
 pub struct StorageDevice {
@@ -457,7 +427,7 @@ pub struct GpuInfo {
 }
 
 /// GPU vendor classification
-#[derive(Debug, Serialize, Deserialize, Clone, PartialEq, Eq)]
+#[derive(Debug, Serialize, Deserialize, Clone, PartialEq, Eq, Default)]
 pub enum GpuVendor {
     /// NVIDIA GPU
     Nvidia,
@@ -468,6 +438,7 @@ pub enum GpuVendor {
     /// Apple GPU (Apple Silicon)
     Apple,
     /// Unknown vendor
+    #[default]
     Unknown,
 }
 
@@ -494,12 +465,6 @@ impl GpuVendor {
     }
 }
 
-impl Default for GpuVendor {
-    fn default() -> Self {
-        GpuVendor::Unknown
-    }
-}
-
 /// GPU device information
 #[derive(Debug, Serialize, Deserialize, Clone)]
 pub struct GpuDevice {
@@ -584,7 +549,7 @@ pub struct NetworkInfo {
 }
 
 /// Network interface type classification
-#[derive(Debug, Serialize, Deserialize, Clone, PartialEq, Eq)]
+#[derive(Debug, Serialize, Deserialize, Clone, PartialEq, Eq, Default)]
 pub enum NetworkInterfaceType {
     /// Physical Ethernet interface
     Ethernet,
@@ -607,15 +572,10 @@ pub enum NetworkInterfaceType {
     /// Macvlan interface
     Macvlan,
     /// Unknown type
+    #[default]
     Unknown,
 }
 
-impl Default for NetworkInterfaceType {
-    fn default() -> Self {
-        NetworkInterfaceType::Unknown
-    }
-}
-
 /// Network interface information
 #[derive(Debug, Serialize, Deserialize, Clone)]
 pub struct NetworkInterface {