Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions internal/hooks/client_header.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
package hooks

import (
"net/http"
"strings"

"github.com/sfcompute/sfc-go/internal/config"
)

// sfcClientHeader is the canonical header used by SFC services to identify
// SDK clients. The server-side parser relies on this header rather than the
// generated User-Agent so that our parsing does not break if Speakeasy
// changes the User-Agent format.
const sfcClientHeader = "x-sfc-client"

// ClientHeaderHook sets the x-sfc-client header on every outgoing request.
// The version is captured from the generated User-Agent at SDK init time.
type ClientHeaderHook struct {
headerValue string
}

func (h *ClientHeaderHook) SDKInit(c config.SDKConfiguration) config.SDKConfiguration {
h.headerValue = "speakeasy/go-" + parseSDKVersion(c.UserAgent)
return c
}

func (h *ClientHeaderHook) BeforeRequest(_ BeforeRequestContext, req *http.Request) (*http.Request, error) {
req.Header.Set(sfcClientHeader, h.headerValue)
return req, nil
}

// parseSDKVersion extracts the SDK version (second token) from the
// Speakeasy-generated User-Agent string of the form:
//
// "speakeasy-sdk/go <sdkVersion> <generatorVersion> <docVersion> <module>"
//
// Returns "unknown" if the User-Agent is empty or does not have at least two
// space-separated tokens.
func parseSDKVersion(userAgent string) string {
parts := strings.Fields(userAgent)
if len(parts) < 2 {
return "unknown"
}
return parts[1]
}
52 changes: 52 additions & 0 deletions internal/hooks/client_header_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
package hooks

import (
"net/http"
"testing"

"github.com/sfcompute/sfc-go/internal/config"
)

func TestClientHeaderHook(t *testing.T) {
tests := []struct {
name string
userAgent string
want string
}{
{
name: "speakeasy generated user agent",
userAgent: "speakeasy-sdk/go 0.0.1 2.881.17 0.1.0 github.com/sfcompute/sfc-go",
want: "speakeasy/go-0.0.1",
},
{
name: "empty user agent",
userAgent: "",
want: "speakeasy/go-unknown",
},
{
name: "single-token user agent",
userAgent: "speakeasy-sdk/go",
want: "speakeasy/go-unknown",
},
}

for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
h := &ClientHeaderHook{}
h.SDKInit(config.SDKConfiguration{UserAgent: tc.userAgent})

req, err := http.NewRequest(http.MethodGet, "https://api.sfcompute.com/v1/foo", nil)
if err != nil {
t.Fatalf("NewRequest: %v", err)
}

if _, err := h.BeforeRequest(BeforeRequestContext{}, req); err != nil {
t.Fatalf("BeforeRequest: %v", err)
}

if got := req.Header.Get(sfcClientHeader); got != tc.want {
t.Errorf("x-sfc-client = %q, want %q", got, tc.want)
}
})
}
}
2 changes: 2 additions & 0 deletions internal/hooks/hooks.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ func New() *Hooks {
afterErrorHook: []afterErrorHook{},
}

initHooks(h)

return h
}

Expand Down
10 changes: 10 additions & 0 deletions internal/hooks/registration.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package hooks

// initHooks is invoked by Hooks.New (in hooks.go) and registers all custom
// hooks for this SDK. This file is user-owned and preserved across Speakeasy
// regenerations.
func initHooks(h *Hooks) {
clientHeader := &ClientHeaderHook{}
h.registerSDKInitHook(clientHeader)
h.registerBeforeRequestHook(clientHeader)
}