fix: codebase correctness audit fixes (#145)#151
Merged
Conversation
Cross-SDK comparison at v0.2.0 showing ~65% coverage (up from ~50%). All Tier 1 items complete. Replaces interim v0.1.0 report. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…147) Replace manual bump_map (keyed by height) with Beef#merge_bump which correctly handles multiple merkle paths at the same block height. The old code silently dropped the second path when two ancestors were proven in the same block. Implements sub-task #147 of HLR #145. Co-Authored-By: Claude <noreply@anthropic.com>
…150) - FORKID enforcement: verify interpreter rejects sighash without FORKID - ExtendedKey fingerprint chain: verify parent→child→grandchild integrity - Mnemonic entropy round-trip: verify all 5 valid entropy lengths Implements sub-task #150 of HLR #145. Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses all findings from the v0.2.0 codebase correctness audit (#145):
TypeErrorcrash in script parser on truncated OP_PUSHDATA1/2/4 opcodes — now raisesArgumentErrorwith descriptive messageTransaction#to_beefsilently dropping second merkle path when two ancestors share a block height — now usesBeef#merge_bumpmod_addinPrivateKey#derive_childtxidand BEEF methods (actually display byte order)Test plan
mod_addrefactor🤖 Generated with Claude Code