feat: AES-256-GCM symmetric encryption (#152)#160
Merged
Conversation
30 specs covering round-trip, error handling, short key padding, and cross-SDK interoperability. Includes all 5 Go SDK test vectors plus bidirectional TS/Go compatibility vectors for both 31-byte and 32-byte keys. Implements sub-task #158 of HLR #152. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- Skip cipher.update for empty plaintext (raises ArgumentError on Ruby 2.7-3.1 OpenSSL versions) - Flatten bidirectional test vectors to avoid RSpec/NestedGroups offence Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Same cipher.update('') issue as encrypt — skip update when the
ciphertext portion is empty (empty plaintext round-trip).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BSV::Primitives::SymmetricKeywith AES-256-GCM encrypt/decrypt matching the TS/Go/Python reference SDK interfaceIV (32 bytes) | ciphertext | auth tag (16 bytes)— cross-SDK compatibleSymmetricKey.from_ecdh(private_key, public_key)derives key from ECDH shared secretTest plan
Closes #152, #157, #158, #159
🤖 Generated with Claude Code