[CLI] Expose --cpu-offload-gb, --tp-size, and --mem-fraction-static on sgl-omni#308
Open
edwingao28 wants to merge 1 commit intosgl-project:mainfrom
Open
[CLI] Expose --cpu-offload-gb, --tp-size, and --mem-fraction-static on sgl-omni#308edwingao28 wants to merge 1 commit intosgl-project:mainfrom
edwingao28 wants to merge 1 commit intosgl-project:mainfrom
Conversation
16f795f to
ee90710
Compare
ee90710 to
53a612b
Compare
5 tasks
53a612b to
6ae047c
Compare
6ae047c to
f2703c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
sgl-omni serveonly exposed high-level options; common SGLang runtime settings likecpu_offload_gb,mem_fraction_static, andtp_sizerequired editing pipeline config YAML by hand. This blocks Ming-flash-omni-2.0 launches, where the generated defaults (cpu_offload_gb=0,mem_fraction_static=0.7) are often too tight, and blocks multi-GPU runs that needtp_size>1.4.22 put this PR on hold since we are facing major codebase refactor, will apply changes after refactored code pushed to main branch
Modifications
--cpu-offload-gb,--mem-fraction-static, and--tp-size; pass asserver_args_overridesviaConfigManager.from_model_pathor--config.server_args_overridesand_apply_server_args_overridestoPipelineConfig; route viaprimary_sglang_stage.server_args_overridesthroughConfigManager.from_model_path.primary_sglang_stage = THINKER_STAGE; auto-injectdisable_custom_all_reduce=Truewhentp_size>1(Ming custom all-reduce kernel hangs under TP); remove legacy local override logic.Example
TP=1:
TP=2 (Ming-Omni):
Related Issues
Closes #296
Checklist