Fix installation instructions for Python 3.13 incompatibility and improve the sanity check example#381
Open
kevin85421 wants to merge 4 commits intosgl-project:mainfrom
Open
Fix installation instructions for Python 3.13 incompatibility and improve the sanity check example#381kevin85421 wants to merge 4 commits intosgl-project:mainfrom
kevin85421 wants to merge 4 commits intosgl-project:mainfrom
Conversation
zhaochenyang20
requested changes
May 4, 2026
| "images": ["tests/data/cars.jpg"], | ||
| "modalities": ["text"], | ||
| "max_tokens": 16, | ||
| "max_tokens": 1024, |
Collaborator
There was a problem hiding this comment.
I'm good with the current docs. Do not need to change it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Modifications
Modification 1: Change from Python 3.13 to 3.12.
On Python 3.13,
uv pip install -v -e .fails because outlines-core v0.1.26 is incompatible with it.outlines-coreonly has wheels for Python 3.9-3.12.The next step is to bump
outlinesin upstream SGLang and then update SGLang Omni to pin to the new SGLang release.Modification 2: Change
max_tokensfrom 16 to 1024The example uses
"max_tokens": 16, which is too low for the model to finish answering, so it does not serve as a meaningful sanity check.Checklist
CI
CI runs on self-hosted GPU runners and requires a maintainer to add the
run-cilabel. Once labeled, every subsequent push re-triggers CI aslong as the label remains. Draft PRs are skipped even if labeled.