[Refactor] Remove unused ModelWorker.get_worker_info#399
Open
kevin85421 wants to merge 1 commit intosgl-project:mainfrom
Open
[Refactor] Remove unused ModelWorker.get_worker_info#399kevin85421 wants to merge 1 commit intosgl-project:mainfrom
kevin85421 wants to merge 1 commit intosgl-project:mainfrom
Conversation
OmniScheduler reads these fields directly from tp_worker.model_runner / server_args, so the method is dead code. Update the now-stale comment in omni_scheduler.py that referenced it. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
JingwenGu0829
approved these changes
May 5, 2026
Collaborator
JingwenGu0829
left a comment
There was a problem hiding this comment.
Thanks! That's what I forgot to delete when I realized the TP implementation deviates from the original design.
Please feel free to raise any further related issue around the TP design (It's not actively used in current models and there's changes half-way in design when TP is being implemented so there could be some issues and dead code.)
Contributor
Author
|
Thanks! I've recently been reading the source code to learn more about SGLang Omni. I'll open some refactor PRs if I find any issues as I go through the codebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OmniScheduler reads these fields directly from tp_worker.model_runner / server_args, so the method is dead code. Update the now-stale comment in omni_scheduler.py that referenced it.
Checklist
CI
CI runs on self-hosted GPU runners and requires a maintainer to add the
run-cilabel. Once labeled, every subsequent push re-triggers CI aslong as the label remains. Draft PRs are skipped even if labeled.