Skip to content

[Refactor] Remove unused ModelWorker.get_worker_info#399

Open
kevin85421 wants to merge 1 commit intosgl-project:mainfrom
kevin85421:refactor-get-worker-info
Open

[Refactor] Remove unused ModelWorker.get_worker_info#399
kevin85421 wants to merge 1 commit intosgl-project:mainfrom
kevin85421:refactor-get-worker-info

Conversation

@kevin85421
Copy link
Copy Markdown
Contributor

@kevin85421 kevin85421 commented May 5, 2026

OmniScheduler reads these fields directly from tp_worker.model_runner / server_args, so the method is dead code. Update the now-stale comment in omni_scheduler.py that referenced it.

Checklist

  • Format your code according with pre-commit.
  • Add unit tests.
  • Update documentation / docstrings / example tutorials as needed.
  • Provide throughput / latency benchmark results and accuracy evaluation results as needed.
  • For reviewers: If you haven't made any contributions to this PR and are only assisting with merging the main branch, please remove yourself as a co-author when merging the PR.

CI

CI runs on self-hosted GPU runners and requires a maintainer to add the
run-ci label. Once labeled, every subsequent push re-triggers CI as
long as the label remains. Draft PRs are skipped even if labeled.

OmniScheduler reads these fields directly from tp_worker.model_runner /
server_args, so the method is dead code. Update the now-stale comment in
omni_scheduler.py that referenced it.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Copy link
Copy Markdown
Collaborator

@JingwenGu0829 JingwenGu0829 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That's what I forgot to delete when I realized the TP implementation deviates from the original design.

Please feel free to raise any further related issue around the TP design (It's not actively used in current models and there's changes half-way in design when TP is being implemented so there could be some issues and dead code.)

@JingwenGu0829 JingwenGu0829 added the run-ci Triggers GPU CI workflows label May 6, 2026
@kevin85421
Copy link
Copy Markdown
Contributor Author

Thanks! I've recently been reading the source code to learn more about SGLang Omni. I'll open some refactor PRs if I find any issues as I go through the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-ci Triggers GPU CI workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants