-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[VLM] Support request level max_dynamic_patch for OpenAI request #16268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @yuan-luo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enables fine-grained control over multimodal processing by allowing users to define the maximum and minimum number of dynamic patches for images and videos at the individual request level. This feature is particularly beneficial for models like InternVL, which utilize dynamic patching to adapt to varying image resolutions and content, providing greater flexibility and optimization for diverse multimodal tasks within an OpenAI-compatible API. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for request-level max_dynamic_patch for OpenAI requests, enhancing multimodal handling capabilities. The changes are generally well-implemented across protocol definitions, serving logic, and multimodal processors. However, I've identified a critical bug in jinja_template_utils.py where a variable is used without initialization, which could lead to incorrect behavior when processing video URLs. Additionally, I've provided suggestions to refactor duplicated code in serving_chat.py and internvl.py to improve code maintainability. Addressing these points will strengthen the robustness of this new feature.
91c201a to
1c66938
Compare
|
/tag-and-rerun-ci |
|
There's regression on Qwen VL model. Checking. |
|
In Qwen2.5-VL, it will parse the |
Problem fixed with adding normalization logic in QwenVL model process_mm_data_async. |
1c66938 to
749e5a3
Compare
|
/rerun-failed-ci |
1 similar comment
|
/rerun-failed-ci |
Motivation
In the InternVL model, max_dynamic_patch is a configuration parameter that defines the maximum number of image patches (or regions) to dynamically extract and process from an image, allowing the model to handle varying image resolutions and content by focusing on important areas, typically defaulting to 12 (InternVL3_5) but configurable for different tasks and model versions. It works with min_dynamic_patch (default 1) to allow for a range of patch counts, enhancing flexibility for multi-image/multi-round conversations and detailed image understanding.
This PR supports request level
max_dynamic_patchfor OpenAI chat/completion request. It works for both image and video.Server:
Client:
Modifications
Accuracy Tests
Main:
PR:
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci) or contact authorized users to do so.