-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Fix crash dump replay script for image data replay #16277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix crash dump replay script for image data replay #16277
Conversation
Summary of ChangesHello @ConnorLi96, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where replaying crash dumps containing multimodal requests would fail because Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively addresses a bug in replaying crash dumps with multimodal data by normalizing the data structure before it's sent to the API. The logic is sound and the changes are well-targeted. I have one suggestion to refactor a new helper function to be more robust and readable by using recursion, which will allow it to handle arbitrarily nested data structures.
| def normalize_mm_data(data): | ||
| if data is None: | ||
| return None | ||
| if isinstance(data, list): | ||
| return [ | ||
| ( | ||
| [normalize_mm_data_item(item) for item in sublist] | ||
| if isinstance(sublist, list) | ||
| else normalize_mm_data_item(sublist) | ||
| ) | ||
| for sublist in data | ||
| ] | ||
| return normalize_mm_data_item(data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The normalize_mm_data function can be simplified and made more robust. The current implementation is somewhat complex and only handles a single level of list nesting. A recursive approach would be cleaner, more concise, and capable of handling arbitrarily nested lists of multimodal data. This also removes the need for the explicit if data is None check, as the recursive call handles it gracefully.
def normalize_mm_data(data):
if isinstance(data, list):
return [normalize_mm_data(item) for item in data]
return normalize_mm_data_item(data)
Motivation
When replaying crash dumps containing multimodal requests (images/videos/audio), asdict() converts ImageData objects to
{'url': '...'}dicts, but the /generate API expects plain URL strings. This causes replay failures for multimodal requests.Modifications
Added
normalize_mm_data_item(): Converts{'url': '...'}dict back to plain URL stringAdded
normalize_mm_data(): Handles nested list structures in multimodal data fieldsAdded
normalize_request_data(): Normalizes image_data, video_data, audio_data fields after asdict() conversionUpdated
run_one_request_internal()to use the normalization pipelineAccuracy Tests
N/A
Just script update and have verified locally, no need to do Accuracy and Benchmarking test.
Benchmarking and Profiling
N/A
Checklist