-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[Fix] Only add SM90 and SM100 to check for auto-enabling TRT Allreduce Fusion #16283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Fix] Only add SM90 and SM100 to check for auto-enabling TRT Allreduce Fusion #16283
Conversation
Summary of ChangesHello @b8zhong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a compatibility issue by adjusting the logic for automatically enabling TensorRT (TRT) Allreduce Fusion. Previously, the fusion could be activated on GPU architectures, such as SM120, that do not support it. The modification restricts the auto-enabling mechanism to only SM90 and SM100 architectures, ensuring that the feature is only utilized on compatible hardware and preventing potential runtime errors or incorrect behavior. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/tag-and-rerun-ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request restricts the auto-enabling of TRT Allreduce Fusion to SM90 and SM100 architectures, removing support for SM120 which is not compatible. The change aligns with the provided context from Flashinfer's source code. I've added one comment regarding an outdated code comment that should be updated for clarity and maintainability.
Motivation
Fix #15650
Modifications
Accidentally did not check Flashinfer repo. It is not compatible with SM120, so we shouldn't enable it here.
Source from Flashinfer (https://github.com/flashinfer-ai/flashinfer/blob/main/flashinfer/jit/comm.py)
Accuracy Tests
N/A
Benchmarking and Profiling
N/A
Checklist