Remove redundant server_args log in Engine.__init__

[xyuzh]

Summary

• Remove duplicate logger.info(f"{server_args=}") in Engine.__init__ since the same log is already emitted in _launch_subprocesses, which is called immediately after.

Test plan

• No behavioral change; only removes a redundant log statement.

[gemini-code-assist]

Summary of Changes

Hello @xyuzh, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on code cleanup by eliminating a redundant log statement. The change ensures that the server_args information is logged only once, improving log clarity without altering any functional behavior of the application.

Highlights

• Logging Redundancy: Removed a duplicate logger.info(f"{server_args=}") statement from the Engine.__init__ method. This log was already being emitted immediately after in _launch_subprocesses, making the one in __init__ redundant.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• python/sglang/srt/entrypoints/engine.py
  • Removed a duplicate logger.info call for server_args from the __init__ method.

Activity

• No review activity or comments have been recorded yet for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes a redundant log statement for server_args in the Engine.__init__ method. The same information is already logged within the _launch_subprocesses function, which is called immediately after. The change is a good cleanup that improves code clarity by eliminating duplication. I've reviewed the change and it looks correct. Well done.