Fix HybridAttnBackend forward for linear attention#19006
Fix HybridAttnBackend forward for linear attention#19006akhilg-nv wants to merge 2 commits intosgl-project:mainfrom
Conversation
HybridAttnBackend lacked a forward() method, causing TypeError when RadixLinearAttention called attn_backend.forward() with mixed_qkv, a, b arguments. Added forward() method that accepts both regular attention (q, k, v) and linear attention (mixed_qkv, a, b) interfaces and routes to the appropriate HybridLinearAttnBackend.
Summary of ChangesHello @akhilg-nv, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug in the HybridAttnBackend that caused a TypeError when attempting to use linear attention. By introducing a comprehensive forward() method, the system can now seamlessly handle both standard and linear attention mechanisms, ensuring proper functionality for hybrid attention layers like those found in Qwen3-Next models. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a TypeError by adding a forward method to HybridAttnBackend. This new method properly handles both standard and linear attention arguments by delegating the call to the appropriate backend based on the forward mode. The change is clean and directly solves the described issue. I've added a couple of comments regarding type hint consistency which could prevent potential runtime errors.
Fixes #18983
Motivation
HybridAttnBackendlacked aforward()method, causingTypeErrorwhenRadixLinearAttentioncalledattn_backend.forward()withmixed_qkv, a, barguments. This occurs for hybrid attention models (e.g., Qwen3-Next) when we select different attention backends for prefill/decode.Modifications
Added
forward()method that accepts both regular attention (q, k, v) and linear attention (mixed_qkv, a, b) interfaces and routes to the appropriateHybridLinearAttnBackend.Accuracy Tests
Validated that it runs, and briefly tested GPQA on a much smaller sample for sanity.
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci