Support cleanup previous dumps in dumper#19013
Support cleanup previous dumps in dumper#19013fzyzcjy wants to merge 4 commits intosgl-project:mainfrom
Conversation
When SGLANG_DUMPER_CLEANUP=1, all existing sglang_dump_* directories under the base dir are removed before the first dump write to disk. Rank 0 performs the cleanup with a distributed barrier for sync.
Summary of ChangesHello @fzyzcjy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the SGLang dumper utility by adding a new feature to automatically clean up old dump directories. This prevents the accumulation of debugging data over time, improving disk space management for users who frequently use the dumper. The cleanup is triggered before the first dump operation when explicitly enabled via an environment variable. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a helpful feature to the dumper utility for automatically cleaning up previous dump files. The implementation is clear and includes corresponding tests. My review includes a fix for a bug in the new test case and a minor style suggestion to improve code consistency.
There was a problem hiding this comment.
There's a typo in the keyword argument. The _Dumper constructor expects cleanup_previous, but needs_cleanup is provided. This will cause a TypeError when running the test.
| dumper = _make_test_dumper(tmp_path, needs_cleanup=True) | |
| dumper = _make_test_dumper(tmp_path, cleanup_previous=True) |
|
|
||
|
|
||
| def _cleanup_old_dumps(base_dir: Path) -> None: | ||
| import shutil |
There was a problem hiding this comment.
According to the PEP 8 style guide, imports should be placed at the top of the file. Please move import shutil to the module-level imports for better code organization and readability.
References
- PEP 8 advises that imports should be at the top of the file, just after any module comments and docstrings, and before module globals and constants. This is for clarity and to make it easy to see what modules a file uses. (link)
(cherry picked from commit 402ad07)
1 participant
Motivation
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci