Skip to content

[scheduler] Add scheduler metrics reporter init hook#29535

Open
yinghai wants to merge 1 commit into
sgl-project:mainfrom
yinghai:yinghai/init-metrics-reporter-hook
Open

[scheduler] Add scheduler metrics reporter init hook#29535
yinghai wants to merge 1 commit into
sgl-project:mainfrom
yinghai:yinghai/init-metrics-reporter-hook

Conversation

@yinghai

@yinghai yinghai commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Route Scheduler metrics reporter construction through an overridable init hook.
  • Preserve the existing default SchedulerMetricsReporter behavior.
  • Allow subclasses to provide specialized reporter implementations without mutating module globals.

Testing

  • uv run python -m py_compile python/sglang/srt/managers/scheduler.py

Original commits

  • e9a406f13

CI States

Latest PR Test (Base): ❌ Run #28308012065
Latest PR Test (Extra): ❌ Run #28308012005

Route Scheduler metrics reporter construction through an overridable factory method. This keeps the default reporter behavior unchanged while allowing subclasses to provide specialized reporter implementations without mutating module globals.

Co-authored-by: Yinghai Lu <yinghai@meta.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@yinghai

yinghai commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

/tag-and-rerun-ci

@yinghai yinghai changed the title Add scheduler metrics reporter init hook [scheduler] Add scheduler metrics reporter init hook Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant