Skip to content

Fix SHM feature finalization under DP attention#29536

Open
yinghai wants to merge 1 commit into
sgl-project:mainfrom
yinghai:yinghai/fix-dp-attn-shm-barrier
Open

Fix SHM feature finalization under DP attention#29536
yinghai wants to merge 1 commit into
sgl-project:mainfrom
yinghai:yinghai/fix-dp-attn-shm-barrier

Conversation

@yinghai

@yinghai yinghai commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Synchronize on the CPU groups that broadcast SHM-backed multimodal work requests before materializing and unlinking those features.
  • Preserve the existing TP-group barrier behavior for the non-DP-attention path.
  • Add focused unit coverage for DP-attention, non-DP-attention, and no-SHM finalization behavior.

Testing

  • uv run python -m py_compile python/sglang/srt/managers/scheduler_components/request_receiver.py test/registered/unit/managers/test_request_receiver_shm_finalize.py
  • uv run python -m pytest test/registered/unit/managers/test_request_receiver_shm_finalize.py (could not run locally: pytest is not installed in this environment)

Source commits

  • 5058b632

CI States

Latest PR Test (Base): ❌ Run #28308122067
Latest PR Test (Extra): ❌ Run #28308122022

Synchronize the CPU groups used to broadcast SHM-backed multimodal work requests before materializing and unlinking the shared-memory features. This preserves the existing TP-group barrier for the non-DP-attention path and adds focused unit coverage for the finalization behavior.

Co-authored-by: Yinghai Lu <yinghai@meta.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@yinghai

yinghai commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

/tag-and-rerun-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant