-
Notifications
You must be signed in to change notification settings - Fork 1.9k
refactor apply_w8a8_block_fp8_linear in fp #6545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor apply_w8a8_block_fp8_linear in fp #6545
Conversation
Hi! I have create a new commit. Here are some bullet points
Some choices I make, which may potentially have some improve space
Please check if any futhur modification is needed! |
Hi ! Here are some modification for this commit
Feel free to tell me if there anything needs further modification! |
Hi! Typo fixed. Feel free to tell me if there is any more issue! |
cc @HaiShaw |
@Alcanderian hi, I click update branch to merge from |
Co-authored-by: Xiaoyu Zhang <[email protected]>
… universal entry for testing purpose
Co-authored-by: JieXin Liang <[email protected]>
d9da17a
to
48e3781
Compare
@Alcanderian thanks for pointing that out! fix that now. Can you run CI again? |
Hi! I think I have fixed 2 minor bugs and the CI seems be correct ( the failing one is not actually failing and 9 pipelines are blocking). Feel free to tell me if any more adjustment needed before merge! Thanks you all guys for the help :) |
See also: #4353
Motivation
refactor apply_w8a8_block_fp8_linear to make the logic more clear and more meaningful
Modifications
only refactor apply_w8a8_block_fp8_linear in fb8_utils
Checklist