Skip to content

added support for tied weights in qwen pipeline parallelism #6546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 25, 2025

Conversation

FrankLeeeee
Copy link
Collaborator

Motivation

Some Qwen variants have tie_word_embeddings = true, however, the current code only caters to case where its value is false. If this value is true, the last rank cannot tie weights successfully since the embed tokens is a PPMissingLayer on the last rank.

I have added logic to:

  1. handle embedding weights send/recv for PP
  2. handle weight loading for PP

Checklist

@Ying1123 Ying1123 merged commit 3f23d8c into sgl-project:main May 25, 2025
124 of 137 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants