Skip to content

Fix VLM CI and eliminate incorrect dependency on pixel values. #6584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

lifuhuang
Copy link
Collaborator

@lifuhuang lifuhuang commented May 25, 2025

Motivation

When I was merging change to support Kimi-VL, I noticed my CI was failing. Upon further investigation, I noticed some seemingly unexpected behaviors:

  • the current VLMInputTestBase.test_understands_image is actually unexpectedly triggering the precomputed feature path, while it should have triggered the raw image path.
  • Gemma3 and Qwen precomputed feature path are both taking dependency on pixel_values, which, based on my limited understanding, defeats the purpose of precomputed feature, which should have only taken dependency on precomputed feature themselves.

Modifications

  1. Remove seemingly incorrect dependency on pixel values when precomputed features are provided.
  2. Pass raw image url instead of processor output in test_understands_image tests.
  3. Replace incorrect usage of processor with tokenizer in test_understands_image as per offline discussion with @mickqian

Checklist

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this change: improving naming from my last PR, sorry :P

@lifuhuang
Copy link
Collaborator Author

Discussed with @JustinTong0323, my understanding was wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants