Private variables/methods made protected #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this project is no longer maintained, people who would still like to use it should create a child class of the original implementation and make changes in the child class. To do this, we need to open up private declarations as protected. For example, the PAYPAL_HOST & SANDBOX_HOST used in this project are incorrect (should be ipnpb.paypal.com & ipnpb.sandbox.paypal.com). Since these are const values, they cannot be changed even in child classes. However, we could override the getPaypalHost method in a child class and make it return the correct urls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this project is no longer maintained, people who would still like to use it should create a child class of the original implementation and make changes in the child class. To do this, we need to open up private declarations as protected.
For example, the PAYPAL_HOST & SANDBOX_HOST used in this project are incorrect (should be ipnpb.paypal.com & ipnpb.sandbox.paypal.com). Since these are const values, they cannot be changed even in child classes. However, we could override the getPaypalHost method in a child class and make it return the correct urls.