fix(a11y): add aria-hidden to skeleton component#10159
Open
Vegapunk-debug wants to merge 7 commits intoshadcn-ui:mainfrom
Open
fix(a11y): add aria-hidden to skeleton component#10159Vegapunk-debug wants to merge 7 commits intoshadcn-ui:mainfrom
Vegapunk-debug wants to merge 7 commits intoshadcn-ui:mainfrom
Conversation
Contributor
|
@Vegapunk-debug is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@HardikDewra Thanks for the review! Let me know if there's anything else needed from my end! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(a11y): add aria-hidden to skeleton component
Description
The
Skeletoncomponent is a decorative loading placeholder and should be hidden from assistive technologies. This PR addsaria-hidden="true"to all Skeleton variants to prevent screen readers from unnecessarily announcing these elements.This approach is consistent with how other decorative elements in the codebase, such as breadcrumb separators and navigation menu indicators, are already handled.
Changes
Added the
aria-hiddenattribute to the rootdivof the Skeleton component. It is placed before the prop spread to ensure developers can still override it if an edge case requires visibility.Affected Files
registry/new-york-v4/ui/skeleton.tsxregistry/bases/base/ui/skeleton.tsxregistry/bases/radix/ui/skeleton.tsxexamples/base/ui/skeleton.tsxexamples/radix/ui/skeleton.tsxexamples/base/ui-rtl/skeleton.tsxexamples/radix/ui-rtl/skeleton.tsxVerification
THANK YOU