fix(registry): add Accept: application/json header to fetchRegistry#10168
Open
cyphercodes wants to merge 1 commit intoshadcn-ui:mainfrom
Open
fix(registry): add Accept: application/json header to fetchRegistry#10168cyphercodes wants to merge 1 commit intoshadcn-ui:mainfrom
cyphercodes wants to merge 1 commit intoshadcn-ui:mainfrom
Conversation
When fetching from registry URLs, the CLI now sends an Accept: application/json header. This allows custom registries to use content negotiation to serve JSON to the CLI while serving HTML documentation to browsers at the same URL. Fixes shadcn-ui#10164
Contributor
|
@cyphercodes is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @cyphercodes, thanks for opening this! I was working on the same fix and just submitted PR #10179. Since yours was first, I wanted to note that I've included a suite of unit tests in my PR. If you'd like to pull those tests into your PR to make it more robust for the maintainers, feel free! I'll leave mine open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fetching from registry URLs, the CLI now sends an
Accept: application/jsonheader. This allows custom registries to use content negotiation to serve JSON to the CLI while serving HTML documentation to browsers at the same URL.Problem
When using
shadcn addwith a custom registry URL, the CLI doesn't send an Accept header. This prevents registries from using standard HTTP content negotiation to serve different content types based on the client.Solution
Add
Accept: application/jsonheader to the fetch request infetchRegistry.Testing
Fixes #10164