fix(cli): support evaluating tsconfig.app.json for import aliases#10175
Open
aakarsh12x wants to merge 2 commits intoshadcn-ui:mainfrom
Open
fix(cli): support evaluating tsconfig.app.json for import aliases#10175aakarsh12x wants to merge 2 commits intoshadcn-ui:mainfrom
aakarsh12x wants to merge 2 commits intoshadcn-ui:mainfrom
Conversation
Contributor
|
Someone is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a fallback inside the CLI's getTsConfigAliasPrefix initialization preflight to automatically locate import aliases defined in
tsconfig.app.json(ortsconfig.web.json).Previously, if a user scaffolded a modern Vite application, their aliases would be tucked into
tsconfig.app.json. Becausetsconfig-pathsspecifically targetedtsconfig.jsonwithout recursively expanding thereferencesarray, the CLI would falsely throw the"No import alias found"error. This fallback logic taps directly into the existing schema-based getTsConfig utility to check these app-level configurations when the primary lookup yields an emptypathsobject.Related Issue
Fixes #10135
Checklist
pnpm typecheck.tsconfig.json.