fix(slider): Add aria-label to slider thumbs for accessibility#10224
Open
cyphercodes wants to merge 2 commits intoshadcn-ui:mainfrom
Open
fix(slider): Add aria-label to slider thumbs for accessibility#10224cyphercodes wants to merge 2 commits intoshadcn-ui:mainfrom
cyphercodes wants to merge 2 commits intoshadcn-ui:mainfrom
Conversation
When fetching from registry URLs, the CLI now sends an Accept: application/json header. This allows custom registries to use content negotiation to serve JSON to the CLI while serving HTML documentation to browsers at the same URL. Fixes shadcn-ui#10164
Added aria-label attributes to slider thumb components to improve accessibility for screen reader users. Each thumb now has a descriptive label indicating its position (e.g., 'Slider thumb 1 of 2'). This makes multi-thumb range sliders accessible by providing context about which thumb is focused. Fixes shadcn-ui#10221
Contributor
|
@cyphercodes is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added aria-label attributes to slider thumb components to improve accessibility for screen reader users.
Issue
Slider thumbs lacked aria-label attributes, making multi-thumb range sliders inaccessible to screen reader users who couldn't identify which thumb was focused.
Changes
Updated slider components in:
Each thumb now has an aria-label indicating its position (e.g., 'Slider thumb 1 of 2').
Impact
This change improves the accessibility of slider components by providing context to screen reader users about which thumb is focused, especially important for multi-thumb range sliders.
Fixes #10221