fix(cli): migrate radix outputs Slot.Root instead of SlotPrimitive.Slot - #11568
Open
jasleenkaur-qed42 wants to merge 1 commit into
Open
fix(cli): migrate radix outputs Slot.Root instead of SlotPrimitive.Slot#11568jasleenkaur-qed42 wants to merge 1 commit into
jasleenkaur-qed42 wants to merge 1 commit into
Conversation
Align migrate radix Slot output with registry components by keeping
import { Slot } from radix-ui and rewriting usages to Slot.Root.
Contributor
|
@jasleenkaur-qed42 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shadcn migrate radixno longer aliasesSlotasSlotPrimitive.asChildternaries, JSX,ComponentProps<typeof Slot>) are rewritten toSlot.Root, matching v4 registry components.Closes #11564
Test plan
pnpm exec vitest run src/migrations/migrate-radix.test.ts(38 passed)npx shadcn migrate radixon a file that imports@radix-ui/react-slotand confirm output usesimport { Slot } from "radix-ui"andSlot.Root