Skip to content

fix(ui): label combobox icon controls - #11592

Open
liljamesjohn wants to merge 1 commit into
shadcn-ui:mainfrom
liljamesjohn:fix/combobox-control-labels
Open

fix(ui): label combobox icon controls#11592
liljamesjohn wants to merge 1 commit into
shadcn-ui:mainfrom
liljamesjohn:fix/combobox-control-labels

Conversation

@liljamesjohn

Copy link
Copy Markdown

Summary

  • add accessible names to the default combobox popup trigger and clear button
  • derive item-specific chip removal labels from string content, with a generic fallback
  • allow consumers to customize trigger, clear, and chip removal labels

Fixes #11589.

Testing

  • mise exec bun@latest -- pnpm registry:build
  • mise exec bun@latest -- pnpm check
  • NEXT_PUBLIC_APP_URL=http://localhost:4000 NEXT_PUBLIC_V0_URL=https://v0.dev mise exec bun@latest -- pnpm test (1,815 passed; one unrelated transformer test exceeded its 8-second timeout under parallel load and passed standalone)
  • verified Base and Radix examples in browser accessibility trees: Open popup, Clear selection, and item-specific removal names are exposed

@vercel

vercel Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

@liljamesjohn is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: Base UI Combobox icon controls lack accessible names

1 participant