feat(avatar): fix badge clipping and align documentation examples#9687
Open
bae080311 wants to merge 24 commits intoshadcn-ui:mainfrom
Open
feat(avatar): fix badge clipping and align documentation examples#9687bae080311 wants to merge 24 commits intoshadcn-ui:mainfrom
bae080311 wants to merge 24 commits intoshadcn-ui:mainfrom
Conversation
Contributor
|
@bae080311 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
@bae080311 can we please reopen this? would benefit some projects I've been working on |
95e9ae5 to
40baeaa
Compare
Author
Reopened — thanks for the interest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve. #9678
Summary
This PR fixes an issue where the
AvatarBadgecomponent was being clipped by the rootAvatarcomponent'soverflow: hiddenstyle.It also resolves discrepancies between the documentation examples and the actual component structure.
Changes
Components
overflow-hidden(where applicable) to allow absolutely positioned badges to render without being clipped.rounded-fulltoAvatarImageacross all styles (new-york-v4,base,radix) to ensure the image remains circular even when the root container does not clip its children.Documentation
AvatarBadgeexamples in both Base UI and Radix UI documentation to use consistent and recommended classes.Developer Experience
NEXT_PUBLIC_APP_URLinRootLayoutto prevent runtime errors during local development when the environment variable is not set.Verification
http://localhost:4000).pnpm registry:buildto ensure all registry files were correctly regenerated and formatted.