rdp2tcp: Use Ex functions

[AndreRH]

This actually made it work for me

[shaddybaddah]

Heya. I'm really happy to see someone else can see the value in this. Curious though, what failure were you experiencing that needed to use the Ex functions? I use this patch almost daily. So I'll build your way too, and check. If it works, I'll pull promptly :-)

[shaddybaddah]

Hi. Sorry I just realised... the revision you've modified does work for me in Cygwin, as per #2 . I mentioned this to the package maintainer for Cygwin https://cygwin.com/ml/cygwin/2018-05/msg00265.html.

I think the Linux build worked, but my memory is hazy, and I would need to review.

Have you been able to get this to work in Cygwin, or only Linux?

[shaddybaddah]

Seems to work in Linux too... though looks like the integration really needs a lot more work. It's never been quite stable, and I haven't been able to attack that properly. I'll raise a new issue over it.

[AndreRH]

Hi, thanks for having a look!
I only tried in Linux and everything looks good until you try to actually use rdp2tcp (e.g. adding a forward), then it failed at

FreeRDP/channels/rdp2tcp/client/rdp2tcp_main.c

Line 134 in e6eb967

if (plugin->channelEntryPoints.pVirtualChannelWrite(plugin->openHandle, plugin->buffer, n, NULL) != CHANNEL_RC_OK)

So I had a look, and the called function FreeRDP_VirtualChannelWrite() tried to find the provided openHandle in freerdp_channel_get_open_handle_data() and can't find it, because we're in the wrong context. FreeRDP_VirtualChannelWriteEx() doesn't need to search, because we provide the Inithandle.

Not sure why this failed for me but succeeded for you